[
https://issues.apache.org/jira/browse/SLING-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585966#comment-13585966
]
Felix Meschberger commented on SLING-2212:
------------------------------------------
Thanks for providing the patch.I basically agree, that we should do this. Some
comments, though:
* IMO the null checks in the ServletContext implementations are not required.
The delegatee can be assumed to never be null.
* I am inclined to not implement the dynamic web application building API in
the ServletContext. This API is AFAICT only available during the
ServletContextListener.contextInitialized call and never operative afterwards.
In addition, in the OSGi context we have better ways to build and register
servlets and filters. And finally these methods only allow to add servlets and
filters but don't support removal which is important in an OSGi context. So I
suggest we hard code throwing an IllegalStatetException (or even an
UnsupportedOperationException).
* There is also enhanced request parameter support in Servlet API 3 which
allows for parsing multipart/form-data POST requests. Sling already supports
this but through a different API. We should port our implementation to
implement the new Servlet API 3 API. See
http://sling.markmail.org/thread/ybifmuuv3dwpe37e.
> Implement Servlet API 3.0
> -------------------------
>
> Key: SLING-2212
> URL: https://issues.apache.org/jira/browse/SLING-2212
> Project: Sling
> Issue Type: Improvement
> Components: Engine, Scripting
> Reporter: Aleksander Bandelj
> Attachments: servlet30.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> New versions of Pax Web, Equinox Web, Grizzly and other OSGI web servers will
> use version 3.0 of Servlet API. Sling Engine implementing only 2.5 will not
> run in these. Since Sling Engine implements API interfaces (ServletContext
> notably), it will have to implement new API methods and tighten some existing
> type signatures. Change is supposed to be backward-compatible (Sling Engine
> implementing 3.0 API can be used with 2.5 API as well).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
