[ 
https://issues.apache.org/jira/browse/SLING-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587202#comment-13587202
 ] 

Ben Peter commented on SLING-2730:
----------------------------------

Sounds good. I'm attaching a patch that implements this, with the following 
changes to your proposal:
- default pattern is "**/*.jsp"
- it's applied if includes is null (as there is no way to use **/* in a Javadoc 
comment and it didn't seem appropriate to change everything to Mojo Annotations 
just for this)
                
> Allow JSPs to be excluded from compilation in maven-jspc-plugin
> ---------------------------------------------------------------
>
>                 Key: SLING-2730
>                 URL: https://issues.apache.org/jira/browse/SLING-2730
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Maven JSPC Plugin 2.0.6
>            Reporter: Ben Peter
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>         Attachments: SLING-2730.patch, SLING-2730-take2.patch
>
>
> JSPs may contain symbols that are declared not in the JSP itself, but in a 
> JSP that includes it (although that may be considered bad style).
> including.jsp:
> <%String foo = "bar"; %>
> <%@include file="included.jsp" %>
> included.jsp:
> <%= foo %>
> The result is that such a JSP does not compile on its own and the goal will 
> fail.
> This can be circumvented if individual JSPs can be excluded from compilation. 
> Excluding them from the resources to start with does not help, as they are 
> still required for the including JSPs to compile.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to