[
https://issues.apache.org/jira/browse/SLING-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592326#comment-13592326
]
Mike Müller commented on SLING-2698:
------------------------------------
To be clear here: This is a first shot not the definitive implementation. I
wanted to share this as soon as possible.
- Yes, we need tests for this new service. Help is very welcome here, I haven't
wrote any integration tests (which I think are needed here?) for sling by
now... but by now
- If no ResourceAccessGate is registered absolutely nothing changes:
ResourceAccessGateTracker keeps track if a ResourceGateAccess is registered and
only if at least one service is registered the AccessGateResourceDecorator is
instantiated and registered as a service.
- I know that regexp are not very fast, but regexp should be allowed, when
using ResourceAccessGate to make it as flexible as possible. My idea is, that
if we ran into performance problems, maybe a cache of often used paths can help.
- To implement the whole service in a separate bundle is maybe not a good idea.
We would need extension points for each operation (CRUD) and also to implement
ResourceAccessGate#sanitizeQuery.
- We can overwrite getResource() on the wrapper. The resource can not be
unwrapped then, but - and Julian is right there - the wrapped resource can be
adapted to some object...
Further thoughts see the discussion unter [1] (important: It is not a
replacement of ACLs!)
[1] http://markmail.org/thread/4ctczoiy533tquyl
> Add a minimal resource access gate
> ----------------------------------
>
> Key: SLING-2698
> URL: https://issues.apache.org/jira/browse/SLING-2698
> Project: Sling
> Issue Type: New Feature
> Components: ResourceResolver
> Reporter: Mike Müller
> Assignee: Mike Müller
> Fix For: Resource Resolver 1.1.0
>
>
> Adding a minmal resource access gate as discussed in [1].
> First step is to define the API interface and a minimal implementation which
> allows to define READ access (rest of CRUD can follow later)
> [1] http://markmail.org/thread/4ctczoiy533tquyl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
