[ 
https://issues.apache.org/jira/browse/SLING-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630300#comment-13630300
 ] 

Felix Meschberger edited comment on SLING-2822 at 4/12/13 4:47 PM:
-------------------------------------------------------------------

Sounds interesting.

One minor stylistic nit-pick on the sample rules: I think we should come up 
with a convention of upper vs. lower case characters: The sample uses lower 
case for bundle states and upper case for login states. How about using 
uppercase for constant-like expressions (like the bundle states and the login 
"states") and lower case for variable-like expressions ?

Also (not having looked at the code):
  * Is there a Web Console plugin ?
  * I assume the muppet servlet is registered with the Http Service (and not as 
a Sling Servlet), right ?
  * How does authentication work ?

Oh, and +1 to having it in contrib
                
      was (Author: fmeschbe):
    Sounds interesting.

One minor stylistic nit-pick on the sample rules: I think we should come up 
with a convention of upper vs. lower case characters: The sample uses lower 
case for bundle states and upper case for login states. How about using 
uppercase for constant-like expressions (like the bundle states and the login 
"states") and lower case for variable-like expressions ?

Also (not having looked at the code):
  * Is there a Web Console plugin ?
  * I assume the muppet servlet is registered with the Http Service (and not as 
a Sling Servlet), right ?
  * How does authentication work ?
                  
> Muppet - extensible system health checking tool
> -----------------------------------------------
>
>                 Key: SLING-2822
>                 URL: https://issues.apache.org/jira/browse/SLING-2822
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: nodes.json, setup.bash
>
>
> I have created a prototype at https://github.com/bdelacretaz/muppet-prototype 
> that we might want to move to our contrib folder.
> Muppet (it's like a Puppet, but different (*)) allows you to check the health 
> of a system by defining rules that (out of the box) verify things like the 
> presence of specific OSGi bundles, JMX MBeans values, correct disabling of 
> default Sling credentials, etc.
> New rule types can be defined by adding RuleBuilder OSGi services, there are 
> several examples in this initial code.
> I'll add a how-to for this initial version here. 
> Known issues are:
> -The output does not indicate the value that causes a rule to fail
> -The servlet output is not JSON yet
> -Tags on rules would be nice to be able to run just the performance or 
> security rules for example
> -A rule for checking OSGi configuration parameters would be useful.
> (*) credits to Joerg Hoh for that one, as well as inspiration in 
> https://github.com/joerghoh/cq5-healthcheck

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to