Hi Bertrand, On 4/26/13 12:24 PM, "Bertrand Delacretaz" <[email protected]> wrote:
>Hi Carsten, > >On Fri, Apr 26, 2013 at 9:10 AM, Carsten Ziegeler <[email protected]> >wrote: >> ...The discovery API also does a leader election, so there >> is one dedicated instance which can be used for things that really >>should >> only run on a single instance... > >Are you confident that the ClusterView's "every ClusterView is >guaranteed to have one and only one leader" invariant is adequately >covered by the existing tests? > >Or are you planning more testing to simulate edge cases like timeouts, >intermittent disconnects, PersistenceException etc? A quick look at >the tests seems to indicate that they test happy cases so far - but >maybe I missed something. +1 for more testing to come. The current state of the tests is indeed rather on the happy side of things and more disaster cases should be added. Cheers, Stefan
