another issue is with the function declarations
OLD
<function>
<name>findResources</name>
<function-class>org.apache.sling.scripting.jsp.taglib.SlingFunctions
</function-class>
<function-signature>java.util.Iterator
findResources(org.apache.sling.api.resource.ResourceResolver,
java.lang.String, java.lang.String)
</function-signature>
</function>
NEW
<function>
<name>findResources</name>
<function-class>org.apache.sling.scripting.jsp.taglib.SlingFunctions</function-class>
<function-signature>java.util.Iterator
findResources(org.apache.sling.api.resource.ResourceResolver, java.lang.String,
java.lang.String)</function-signature>
</function>
==> the function-signature must be on the same line
...so should I fix these issues as well?
Ondrej
On 8 May 2013, at 22:48, Dan Klco <[email protected]> wrote:
> Ondrej,
>
> From the code snippet you specified it looks like the version attribute and
> the XSD version did not match in the old copy of the code. I would image
> that would be the source of the issue you described.
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:[email protected]]
> Sent: Wednesday, May 08, 2013 4:36 PM
> To: [email protected]
> Subject: Re: support for JSTL 1.2 (SLING-2648)
>
> Hi Dan,
>
> I am also facing problems getting 'resource tags' working
> (https://issues.apache.org/jira/browse/SLING-2648).
> I ended up changing the taglib tld which seem to fix the problem.
>
> ...I am just wondering whether these are genuine bugs I am facing or whether
> there is something wrong with my build (I did a clean checkout and build
> today)
>
> OLD:
> <taglib xmlns="http://java.sun.com/xml/ns/j2ee";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd";
> version="2.0">
>
> NEW:
> <taglib xmlns="http://java.sun.com/xml/ns/j2ee";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
> http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd";
> version="2.1">
>
>
>
> On 8 May 2013, at 21:42, Dan Klco <[email protected]> wrote:
>
>> Ondrej,
>>
>> This sounds interesting, though it seems like Expression Language support
>> was added in JSTL 1.1, so it should be supported currently. Could you
>> please create an issue and attach a patch file for the proposed change?
>>
>> It looks like the dependency being referenced is GlassFish's JSTL
>> implementation, are there any concerns about including it as it is licensed
>> under the CDDL (https://jstl.java.net/)?
>>
>> From what I have read, it seems like binaries licensed under the CDDL can be
>> included in Apache projects, however since we re-wrap the Jar in a bundle I
>> don't know if it might be problematic. Additionally, I think we will need
>> to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>>
>> -Dan
>>
>> -----Original Message-----
>> From: Ondrej Florian [mailto:[email protected]]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: [email protected]
>> Subject: support for JSTL 1.2
>>
>> Hi,
>>
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't
>> seem to work with the JSP EL.
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13
>> Internal Virus Database is out of date.
>>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13
> Internal Virus Database is out of date.
>
