[
https://issues.apache.org/jira/browse/SLING-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653552#comment-13653552
]
Carsten Ziegeler commented on SLING-2861:
-----------------------------------------
I think we shouldn't do this; first of all each module should use the lowest
version it requires as a dependency and second, if we open this door, we most
likely start to add more than this to the parent pom and get into the
dependency hell problem where you first need to release/update a parent pom,
just to get the right version into a module - unless of course you overwrite
the dependency in the module, which defeats the purpose.
I think there are exceptions to the rule, like the most important APIs we base
on: servlet, jcr, and OSGi. And this also includes the slf4j as we're using
that as our prefered logging api.
In addition, it's fine to define tooling dependencies like the scr annotations
and bnd, because these are used by nearly every module.
> Include Apache Commons Lang in Dependency Management
> ----------------------------------------------------
>
> Key: SLING-2861
> URL: https://issues.apache.org/jira/browse/SLING-2861
> Project: Sling
> Issue Type: Improvement
> Components: General
> Reporter: Dan Klco
> Priority: Minor
>
> Right now, Apache Commons Lang is referenced in 8 locations and two different
> versions (2.4 and 2.5), given this it would seem much cleaner to move Apache
> Commons Lang into the dependency management of the root pom and remove the
> versions from the references.
> trunk
> bundles
> auth
> form
> pom.xml
> 152:
> <artifactId>commons-lang</artifactId>
> extensions
> adapter
> pom.xml
> 152: <artifactId>commons-lang</artifactId>
> servlets
> get
> pom.xml
> 133: <artifactId>commons-lang</artifactId>
> resolver
> pom.xml
> 104: <artifactId>commons-lang</artifactId>
> contrib
> extensions
> rewriter
> pom.xml
> 96:
> <artifactId>commons-lang</artifactId>
> scripting
> script-console
> pom.xml
> 97: <artifactId>commons-lang</artifactId>
> velocity
> pom.xml
> 135: <artifactId>commons-lang</artifactId>
> samples
> urlfilter
> pom.xml
> 95: <artifactId>commons-lang</artifactId>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
