On Mon, 2013-06-03 at 10:00 +0200, Bertrand Delacretaz wrote: > Hi, > > On Fri, May 31, 2013 at 9:14 PM, Robert Munteanu <romb...@apache.org> wrote: > > ...It seems that the ErrorHandlingTest fails sporadically when run inside a > > full maven build... > > I fixed a related issue in SLING-2818 a few weeks ago, is it something else > now?
Yes, the problem persists even after your fix. > > > ....For this test, and for future flaky/failing tests, I > > suggest that we > > > > 1. Create an issue for the failing test > > 2. Disable the test and mark it with the issue key > > 3. Re-enable the test when it is stable/passing ( which may be > > considerably later than step 2) > > 4. Close the issue after the test is re-enabled... > > I agree with that, and I would make the next release of the module in > question dependent on that issue, to make sure we look at it before > releasing. It seems that we don't have a consensus on it, so I'd amend the process to be 1. Create an issue for the failing test 2. Target it for the next release of the affected module ( if applicable ) or for the next version of the launchpad Hopefully that's something which is agreeable to everyone Robert
