For now I'm against committing this to trunk, as previously mentioned I would prefer having a build time annotation. If this is not possible, then the annotation and the AdapterProvider should be in the same package as there is no use case for using one without the other.
One solution for a build time annotation would be to define a server registration property for a AdapterProvider containing the method names and at build time the value of this property would be generated by using the annotation. This would be similar to the bind/unbind methods of DS. Regards Carsten 2013/7/3 Carsten Ziegeler <[email protected]> > Just read the answer in the issue :) > > I like the general intention - however it feels a little bit strange to > register a AdapterProvider, annotate a method and then this gets picked up > at runtime and a new AdapterFactory is registered. > Can't we make this annoation build time only - as an extensions of the SCR > annotations? > > Carsten > > > 2013/7/3 Carsten Ziegeler <[email protected]> > >> Hi, >> >> sounds interesting - could you please elaborate a little bit on who is >> processing this annotation and when? >> >> Thanks >> Carsten >> >> >> 2013/7/3 Bertrand Delacretaz <[email protected]> >> >>> On Wed, Jul 3, 2013 at 3:07 PM, Justin Edelson <[email protected]> >>> wrote: >>> ... >>> > @Adapter(condition="if the resource type is slingbucks/list"). >>> ... >>> >>> Makes sense, noted in SLING-2938 >>> -Bertrand >>> >> >> >> >> -- >> Carsten Ziegeler >> [email protected] >> > > > > -- > Carsten Ziegeler > [email protected] > -- Carsten Ziegeler [email protected]
