On Mon, Jul 22, 2013 at 1:56 PM, Ian Boston <[email protected]> wrote: > Hi Dishara, > > The Unit test coverage sounds great. I will pull the code and review today. > > > Have you tried loading the bundle into a running Sling instance ? > Not yet. I will try that out and let you know in one of following ways Thanks.
> > Once you have built it you can load in 2 ways: > > method A > > mvn clean install sling:install > > The sling:install will post the Jar into the OSGi container over HTTP and > cause it to start. > > > method B > > Goto http://localhost:8080/system/console > > select the bundle tab and install the bundle by uploading. > > If you monitor the logs you should see no errors, the bundle should > register and you should be able to map cassandra read only to somewhere in > the resource tree. > > Best Regards > Ian > > > On 21 July 2013 13:08, Dishara Wijewardana <[email protected]> > wrote: > > > On Sun, Jul 21, 2013 at 5:32 PM, Dishara Wijewardana < > > [email protected]> wrote: > > > > > > > > > > > On Fri, Jul 19, 2013 at 2:35 PM, Ian Boston <[email protected]> wrote: > > > > > >> Hi, > > >> > > >> > > >> On 19 July 2013 03:20, Dishara Wijewardana <[email protected]> > > >> wrote: > > >> > > >> > Hi Ian > > >> > This is regarding the sub tasks completion of the project according > > to > > >> the > > >> > time line. > > >> > > > >> > I have my code locally, but yet to do some completion with some > > >> stuff(one > > >> > of them is the ongoing discussion on listChildren). > > >> > After that from API point of view implementation around Cassandra > > >> Resource > > >> > Provider and Resource will be finish. And I have to add some more > > JUnit > > >> > tests(have local code in to some extent already, will commit them > once > > >> all > > >> > done around this). > > >> > > > >> > So after that (after mid term) what I have to do is enhance the > > >> provider > > >> > implementation to do READ operations with access control. My idea > is > > >> to > > >> > finish that also before the mid term. I was kind of got stuck in > some > > >> OSGi > > >> > stuff last days ;-). And I will make sure I will have JUnit tests > to > > >> cover > > >> > all the implementations before the midterm. > > >> > > > >> > > >> Yes that is fine. > > >> Before adding ACLs I would like to have the code running inside Sling, > > >> inside OSGi connected to a Cassandra instance so that we can do some > > basic > > >> tests over http using Curl. > > >> > > >> Perhaps you are there already? Let me know when you are ready and I'll > > >> give > > >> it a go ? > > >> > > > > > > Hi Ian, > > > That is great and +1. In fact now the code is there and I have > completed, > > > rest of the implementation on normal READ and commited. > > > > > > I have added 3 more tests to cover the core implementation. The tests > > are > > > running which covers add/read nodes, list children,iterate/iterable > > > children and get parent related stuff. > > > > > > > Correction . It should be 4 more tests. Now we have 5 tests all together > > which covers above aspects. We should write more test around Cassandra > > Resource. Will work on that as well. > > > > Please let me know if any issues come across when you run this in the > sling > > container. Excited to see whether it works in there :-). > > > > > > > And I have made the changes you mentioned. So now resources will not > get > > > loaded unless we do a API call with the resource. > > > > > > > > >> > > >> > > >> > If you would like this approach (or unless please provide your > > feedback > > >> on > > >> > what needs to be done before midterm), please advice me on how to > > >> approach > > >> > on READ with access control. Can I do it and test it with keeping my > > >> code > > >> > in Google Code still ? And please add if I have missed anything. > > >> > > > >> > On Thu, Jul 4, 2013 at 11:13 PM, Dishara Wijewardana < > > >> > [email protected]> wrote: > > >> > > > >> > > Hi Ian, > > >> > > I have refactored almost all the code review changes requested. In > > the > > >> > > process of the rest of the implementation. > > >> > > > > >> > > On Wed, Jul 3, 2013 at 12:52 PM, Bertrand Delacretaz < > > >> > > [email protected]> wrote: > > >> > > > > >> > >> Hi Dishara, > > >> > >> > > >> > >> On Tue, Jul 2, 2013 at 6:51 PM, Dishara Wijewardana > > >> > >> <[email protected]> wrote: > > >> > >> > ...Does each bundle in sling made to run their junit tests > > >> separately > > >> > >> at build > > >> > >> > time... > > >> > >> > > >> > >> Could you start new threads with new subject lines when you > start a > > >> > >> new question or discussion? > > >> > >> > > >> > >> Otherwise it's very hard to find things in our mailing list > > archives. > > >> > >> > > >> > >> OK. That's a good idea. I will follow that. > > >> > > > > >> > > > > >> > >> Thanks, and keep up the good work! > > >> > >> -Bertrand > > >> > >> > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Thanks > > >> > > /Dishara > > >> > > > > >> > > > >> > > > >> > > > >> > -- > > >> > Thanks > > >> > /Dishara > > >> > > > >> > > > > > > > > > > > > -- > > > Thanks > > > /Dishara > > > > > > > > > > > -- > > Thanks > > /Dishara > > > -- Thanks /Dishara
