On Tue, Jul 30, 2013 at 12:28 PM, Carsten Ziegeler <[email protected]> wrote:
> ...- I'm not sure whether the info part should be part of the result - if it's
> static it can be part of the interface, but I could imagine that it might
> change and be potentially different between executions....

Yes...the static part does come from the HealthCheck definition, and
the execution can add some values dynamically, makes sense.

> - the ID does not need to be part of the interface, this can be part of the
> service registration properties.

ok, let's try that.

> - tags: i think these could be part of the service registration properties
> as well

ok, and then we need a HealthCheckExecutor service that gets and
executes a set of HealthCheck selected by tags.

>
> The benefit of having the info as service reg props is that the
> filtering/checking can be done without really instantiating/getting the
> services.

ok, the above service will do that then.

Thanks for the review and ideas,
-Bertrand

Reply via email to