[ 
https://issues.apache.org/jira/browse/SLING-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793629#comment-13793629
 ] 

Carsten Ziegeler commented on SLING-3169:
-----------------------------------------

I agree this is a little bit tricky (and confusing) - let's start with the 
obvious one, Job.JobType. I agree this is a state and I choose this name 
because there is JobState in the consumer package :)
Now JobState in the consumer package is more a result, but not quiet. One could 
argue that the result of a job is whatever it produced, so the result of an 
image rendering job is the newly rendered image. Subtle differences I agree, so 
what about renaming JobStatus to JobExecutionResult? (to distinguish it from a 
job result)
We could think about merging JobState and Job.JobType - however there is the 
problem with FAILED vs QUEUED, QUEUED would mean it has never been executed and 
is in the queue, FAILED means it has been executed but processing failed and 
the job is now in the queue.
[[email protected]] WDYT?


> Naming of Job related enumerations
> ----------------------------------
>
>                 Key: SLING-3169
>                 URL: https://issues.apache.org/jira/browse/SLING-3169
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Extensions Event 3.3.0
>
>
> This is a follow up from SLING-3028 based on comments by Stefan Seifert:
>     I find the enum name Job.JobType not ideal, because it does not stand of 
> a type but for a state of the job. But there is a JobState enum in the 
> consumer API package already.
>     I find the enum and class names JobState and JobStatus in the consumer 
> package not ideal, because they do not stand for a state, but for a job 
> result.
>   



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to