[
https://issues.apache.org/jira/browse/SLING-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815155#comment-13815155
]
Tobias Bocanegra commented on SLING-3223:
-----------------------------------------
>> btw: how is deactivate implemented? not via an empty content package?
> an empty package (see VoidReplicationPackage)
but then, is there really a difference between _activate_ and _deacticate_ ?
> they \[_the authentication handlers_] are used for authenticate
> TransportHandlers which may deliver content to either an HTTP endpoint (most
> often) or not (e.g. file system, or other)
ok. consider using a different name, then.
>> the adapter from SlingRequest to ReplicationPackage is really questionable
>> in IMO. It is used in a very specific case and the adaption is considerably
>> expensive. Or do you foresee that other clients of this API adapt a request
>> to a ReplicationPackage ?
> I agree that can be much improved, that's just used from the receiving
> servlet for reading a replication package stream to install the package on
> the receiving instance.
I would get rid of it and put it into an utility class, or into the servlet
where you need it. it just "pollutes" the set of adapters in sling.
> Donation of a replication module for Sling
> ------------------------------------------
>
> Key: SLING-3223
> URL: https://issues.apache.org/jira/browse/SLING-3223
> Project: Sling
> Issue Type: Task
> Components: Extensions
> Reporter: Tommaso Teofili
> Attachments: SLING-3223.patch
>
>
> Issue to track donation of a replication module for Sling, see thread at
> http://markmail.org/thread/ic62k5pc34ppb5ko
--
This message was sent by Atlassian JIRA
(v6.1#6144)
