Hi Justin, Finally found time to review YAMF.
On Thu, Dec 19, 2013 at 6:07 PM, Justin Edelson <[email protected]> wrote: > ...I'm calling this YAMF for now, although ideally > we'll just call it Sling Models... +1 for Sling Models, that's consistent with our general naming. My comments, after looking at the wiki page only: 1) Should it be @SlingModel rather than @Model? By analogy with @SlingServlet. 2) For adaptation, would my SLING-2938 adapter methods prototype make sense? 3) Is it a good idea to use @Inject for both services and resource values? Using @ResourceValue for the latter makes it easier to explain both IMO. 4) Also, would @Path make sense instead of @Named? Does the implementation then support @Path("child-node/some-property") ? 5) @Projection is not obvious to me from its name, how about @ChildPath ? Naming nitpicks mostly, YAMF looks good to me, thanks! -Bertrand
