[ 
https://issues.apache.org/jira/browse/SLING-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865362#comment-13865362
 ] 

Bertrand Delacretaz commented on SLING-3300:
--------------------------------------------

Small nitpick in the servlet, I don't think isXEnabled calls such as this are 
needed in general, except for performance critical code maybe. AFAIK the log 
libraries handle that efficiently for non performance critical use cases.

{code}
if (log.isInfoEnabled()) {
                log.info("agent configuration for {} created", name);
}
{code}

No need to change that right now IMO, but maybe at the next opportunity when 
changes are needed.

> Add an API to create replication agent (configuration)
> ------------------------------------------------------
>
>                 Key: SLING-3300
>                 URL: https://issues.apache.org/jira/browse/SLING-3300
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Tommaso Teofili
>            Assignee: Bertrand Delacretaz
>              Labels: replication
>         Attachments: SLING-3300.patch, SLING-3300.patch
>
>
> Other than retrieving and updating configuration of an agent it's a common 
> need to be able to create an agent configuration (and therefore the agent 
> itself)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to