Felix Meschberger created SLING-3314:
----------------------------------------
Summary: Remove test API from JavaScript wrappers
Key: SLING-3314
URL: https://issues.apache.org/jira/browse/SLING-3314
Project: Sling
Issue Type: Task
Components: Scripting
Affects Versions: Scripting JavaScript 2.0.12
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: Scripting JavaScript 2.0.14
SLING- introduced an abstract method jsGet_javascriptWrapperClass() in the
ScriptableBase class. This method is used by unit tests to verify the
JavaScript host object is provided by the correct implementation class.
This test is problematic on different accounts:
- It creates public API exposing implementation details (the
javascriptWrapperClass property)
- It creates an implementation detail dependency in the tests. The tests must
validate the functionality not whether the provider is the right instance. For
example if the classes would be moved to another package, the tests would fail.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
