[
https://issues.apache.org/jira/browse/SLING-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-3308.
--------------------------------------
Resolution: Fixed
Fix Version/s: Scripting JavaScript 2.0.14
Thanks for the patch again. I have extended it a bit to analyzing where it
might make sense to actually check for null of the embedded fields. Turns out
it is not that drammatic as I thought it would be.
> [Javascript] Upgrading Rhino version from 1.6R2 to 1.7R4
> --------------------------------------------------------
>
> Key: SLING-3308
> URL: https://issues.apache.org/jira/browse/SLING-3308
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JavaScript 2.0.12
> Reporter: rohit
> Assignee: Felix Meschberger
> Fix For: Scripting JavaScript 2.0.14
>
> Attachments: SLING-3308.patch
>
>
> We have a bundle which uses Rhino 1.7 and is incompatible with version 1.6
> currently exposed by org.apache.sling.scripting.javascript bundle. I tried
> building org.apache.sling.scripting.javascript with 1.7R4 version, but
> received test failures. I am currently working on it and any suggestions
> would be very helpful.
> Attaching the patch of pom.xml.
> Stack trace of failed test:
> javax.script.ScriptException: Failure running script NO_SCRIPT_NAME: null
> at
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngine.eval(RhinoJavaScriptEngine.java:158)
> at
> org.apache.sling.scripting.api.AbstractSlingScriptEngine.eval(AbstractSlingScriptEngine.java:44)
> at
> org.apache.sling.scripting.javascript.internal.ScriptEngineHelper.eval(ScriptEngineHelper.java:103)
> at
> org.apache.sling.scripting.javascript.internal.ScriptEngineHelper.evalToString(ScriptEngineHelper.java:83)
> at
> org.apache.sling.scripting.wrapper.ScriptableNodeTest.testForCurrentNode(ScriptableNodeTest.java:279)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:255)
> at junit.framework.TestSuite.run(TestSuite.java:250)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> at
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
> Caused by: java.lang.NullPointerException
> at
> org.apache.sling.scripting.javascript.wrapper.ScriptableNode.has(ScriptableNode.java:406)
> at
> org.mozilla.javascript.ScriptableObject.getBase(ScriptableObject.java:2531)
> at
> org.mozilla.javascript.ScriptableObject.hasProperty(ScriptableObject.java:2284)
> at
> org.mozilla.javascript.ScriptRuntime.toIterator(ScriptRuntime.java:1984)
> at
> org.mozilla.javascript.ScriptRuntime.enumInit(ScriptRuntime.java:2033)
> at
> org.mozilla.javascript.gen.NO_SCRIPT_NAME_41._c_script_0(NO_SCRIPT_NAME:1)
> at org.mozilla.javascript.gen.NO_SCRIPT_NAME_41.call(NO_SCRIPT_NAME)
> at
> org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:394)
> at
> org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3091)
> at org.mozilla.javascript.gen.NO_SCRIPT_NAME_41.call(NO_SCRIPT_NAME)
> at org.mozilla.javascript.gen.NO_SCRIPT_NAME_41.exec(NO_SCRIPT_NAME)
> at org.mozilla.javascript.Context.evaluateReader(Context.java:1110)
> at
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngine.eval(RhinoJavaScriptEngine.java:115)
> ... 29 more
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
