[ 
https://issues.apache.org/jira/browse/SLING-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873087#comment-13873087
 ] 

Georg Henzler commented on SLING-3278:
--------------------------------------

+1 for adding resultCacheTtlInMs as service prop + 
HealthCheckMetadata.getResultTTLMsec()

Regarding the special values: Using zero for "do not cache" is good, for 2. 
"use default TTL" we could maybe use the type Long (instead of long) and the 
value null (and an empty string in the console config UI). "Leave empty for 
using the global default" reads better in the documentation than "Use -1 for 
the global default".

> Provide a HealthCheckExecutor service
> -------------------------------------
>
>                 Key: SLING-3278
>                 URL: https://issues.apache.org/jira/browse/SLING-3278
>             Project: Sling
>          Issue Type: New Feature
>          Components: Health Check
>            Reporter: Georg Henzler
>            Assignee: Carsten Ziegeler
>             Fix For: Health Check Core 1.0.8
>
>         Attachments: SLING-3278-bertrand.patch, 
> SLING-3278-hc.core-HealthCheckExecutorService-2013-12-19.patch, 
> SLING-3278-hc.core-HealthCheckExecutorService-2013-12-21-withExecutorResult.patch,
>  SLING-3278-hc.webconsole-2013-12-19.patch, 
> SLING-3278-hc.webconsole-2013-12-21.patch, 
> SLING-3278-more-explicit-use-of-constructor.patch, hc-it.patch
>
>
> Goals:
> * Be able to get an overall (aggregated) result as quickly as possible 
> (ideally <2sec)
> * Whenever possible, return most current results (e.g. for a memory check)
> * Provide a declarative way for async checks (async checks should be the 
> exception though) 
> Approach
> * Run checks in parallel
> * Make sure long running (or even stuck) checks are timed out
> * If a health check must run asynchronously (because its execution time 
> cannot be optimized), it should be enough to just specify a service property 
> (e.g. "hc.async").
> See also
> http://apache-sling.73963.n3.nabble.com/Health-Check-Improvements-td4029330.html#a4029402
> http://apache-sling.73963.n3.nabble.com/Health-checks-execution-service-td4028477.html



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to