If it is always configured wrongly, then we have the wrong default :) although I don't think that's the case here.
I think the way to handle this without a switch would be to vary behavior based on the number of discovered alias properties. We'd still want to be able to configure the threshold, but we can probably come up with a reasonable default here. I.e. count(sling:alias) < 10k, use preload; otherwise, don't. But I wonder if this is just creating a different performance problem related to the query. I think we can just put an advisory in the metatype saying "Disable this option if you have more than 10,000 aliases." Justin On Thu, Jan 23, 2014 at 10:35 AM, Carsten Ziegeler <[email protected]> wrote: > It would be nice if we can get this solved without a flag - there is a high > chance that this is always configured wrongly. > > Carsten > > > 2014/1/23 Antonio Sanso <[email protected]> > >> hi *, >> >> in SLING-3332 [0] I have proposed to introduce a Configuration flag for >> optimize alias resolution. >> >> The optimization as been introduced as part of SLING-2521 [1] and in >> general is a really good optimization. >> >> There are certain cases though where it would be beneficial to switch this >> implementation off (e.g. when a huge number of sling:alias is present). >> You can find a detailed analysis and a patch in [0]. >> >> I will wait a bit before to apply the patch. >> >> Please raise your hand if you are against it though :) >> >> regards >> >> antonio >> >> >> [0] https://issues.apache.org/jira/browse/SLING-3332 >> [1] https://issues.apache.org/jira/browse/SLING-2521 > > > > > -- > Carsten Ziegeler > [email protected]
