Looks good to me, especially removing the context handling from the api is good as this might be something we need but differently in the future. So not having it there in the first place makes things easier.
Carsten 2014-01-29 Felix Meschberger <[email protected]>: > Hi > > Ok, I drastically cut this thing down and created a patch. > > See https://issues.apache.org/jira/browse/SLING-3350 > > WDYT ? > > Regards > Felix > > Am 29.01.2014 um 16:01 schrieb Felix Meschberger <[email protected]>: > > > Hi > > > > Am 29.01.2014 um 15:53 schrieb Carsten Ziegeler <[email protected]>: > > > >> 2014-01-29 Felix Meschberger <[email protected]> > >> > >>> Hi > >>> The problem really is that the initial resolution does not have the > >>> ResourceResolver available in the context yet, because only the > >>> SlingMainServlet knows about it so far. > >>> > >>> Yepp > >> > >> > >>> So that leaves us with a two options: > >>> > >>> * keep the global filter, which at least sets an initial > >>> HttpSerlvetRequest context > >>> * implement a SlingRequestListener to extract the Resource Resolver > from > >>> the request attribute and add it to the context (instead of the Sling > Level > >>> Filter) > >>> > >>> Hmm, why can't the global filter ask for the request attribute? > > > > Ahh ! Excellent catch ! > > > > Looking back at your messages, it looks like I did not fully understand > what you meant to say earlier. Sorry. > > > > Yes, of course it can do that. > > > > Regards > > Felix > > > >> > >> Carsten > >> > >> -- > >> Carsten Ziegeler > >> [email protected] > > > > -- Carsten Ziegeler [email protected]
