Yes, I'm only using that one atm. So inlining sounds like a good idea! Cheers, Stefan
On 2/5/14 12:26 PM, "Chetan Mehrotra" <[email protected]> wrote: >If you are only going to use SubnetUtils [1] then we can possibly >inline it in the bundle as it appears to be not depending on any other >class in commons-net > >Chetan Mehrotra >[1] >https://github.com/apache/commons-net/blob/trunk/src/main/java/org/apache/ >commons/net/util/SubnetUtils.java > > >On Wed, Feb 5, 2014 at 4:44 PM, Stefan Egli <[email protected]> wrote: >> Just checked. >> >> The exports look clean: only org.apache.commons.net.* >> >> The imports too: javax.crypto,javax.crypto.spec,javax.net,javax.net.ssl >> >> But the size is not tremendously small - it is 280kB.. - but within the >> range of the other apache's commons-* >> >> Cheers, >> Stefan >> >> On 2/5/14 11:53 AM, "Bertrand Delacretaz" <[email protected]> >>wrote: >> >>>Hi Stefan, >>> >>>On Wed, Feb 5, 2014 at 11:46 AM, Stefan Egli <[email protected]> wrote: >>>> ...For implementing SLING-3001 I'd like to include apache's >>>>commons-net >>>>(3.3) as it contains a nice utility >>>> for doing CIDR and mask calculations (SubnetUtils).... >>> >>>What does that mean, is that just a new small bundle with clean >>>package exports/imports? >>> >>>If yes I'm ok with it. >>> >>>-Bertrand >>
