I'm wondering if we need the additional compilation at all? What happens if we set servlet api 3 as the dependency for the project and add the missing methods as stubs to SlingServletContext and ExternalServletContextWrapper? These methods shouldn't be called when in a servlet 2.5 env
Carsten 2014-02-21 10:02 GMT+01:00 Carsten Ziegeler <[email protected]>: > Yeah, I don't want to change my already fragile setup... > > If I remove this dependency: > <dependencies> > <dependency> > <groupId>com.sun</groupId> > <artifactId>tools</artifactId> > <version>1.5.0</version> > <scope>system</scope> > > <systemPath>${java.home}/../lib/tools.jar</systemPath> > </dependency> > </dependencies> > > Everything works fine - so the question is, is this needed? > > Carsten > > > 2014-02-21 9:58 GMT+01:00 Felix Meschberger <[email protected]>: > > Hi >> >> Looks like you are building with the Apple JDK which seems to be >> structured differently. >> >> You might want to try with the OpenJDK 7 ? >> >> Background: When maven runs the ant targets, it sets JAVA_HOME to the >> embedded JRE instead of the JDK it is itself running under. The >> ../lib/tools.jar trick should add the single missing library to the ant >> class path to be able to run the javac target. >> >> Regards >> Felix >> >> Am 21.02.2014 um 09:45 schrieb Carsten Ziegeler <[email protected]>: >> >> > Actually I was wrong, I'm building with a JDK, but there is no tools.jar >> > >> > Carsten >> > >> > >> > 2014-02-21 9:41 GMT+01:00 Carsten Ziegeler <[email protected]>: >> > >> >> Hi, >> >> >> >> on my old mac os x (10.7), I'm not able to build latest Sling Engine >> >> Bundle: >> >> >> >> [WARNING] >> >> [WARNING] Some problems were encountered while building the effective >> >> model for >> org.apache.sling:org.apache.sling.engine:bundle:2.2.11-SNAPSHOT >> >> [WARNING] >> >> >> 'build.plugins.plugin[org.apache.maven.plugins:maven-antrun-plugin].dependencies.dependency.systemPath' >> >> for com.sun:tools:jar refers to a non-existing file >> >> >> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar. >> >> Please verify that you run Maven using a JDK and not just a JRE. @ >> line 98, >> >> column 37 >> >> ... >> >> [ERROR] Failed to execute goal >> >> org.apache.maven.plugins:maven-antrun-plugin:1.7:run >> >> (set-bundle-required-execution-environment) on project >> >> org.apache.sling.engine: Execution >> >> set-bundle-required-execution-environment of goal >> >> org.apache.maven.plugins:maven-antrun-plugin:1.7:run failed: Plugin >> >> org.apache.maven.plugins:maven-antrun-plugin:1.7 or one of its >> dependencies >> >> could not be resolved: Could not find artifact com.sun:tools:jar:1.5.0 >> at >> >> specified path >> >> >> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar >> >> -> [Help 1] >> >> >> >> And indeed I'm building with a JRE, however my java setup is already >> >> messed up totally. >> >> Is there any chance we can fix this in the pom? >> >> >> >> Regards >> >> Carsten >> >> -- >> >> Carsten Ziegeler >> >> [email protected] >> >> >> > >> > >> > >> > -- >> > Carsten Ziegeler >> > [email protected] >> >> > > > -- > Carsten Ziegeler > [email protected] > -- Carsten Ziegeler [email protected]
