[
https://issues.apache.org/jira/browse/SLING-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910135#comment-13910135
]
Bertrand Delacretaz commented on SLING-3407:
--------------------------------------------
+1 in general.
If getDefaultLocale() is actually handled in higher layers I agree with your
proposal to deprecate it, but don't you then risk of getting a null Locale?
Might be good to check for null in the getrRsourceBundle methods.
> ResourceBundleManager API
> -------------------------
>
> Key: SLING-3407
> URL: https://issues.apache.org/jira/browse/SLING-3407
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
> Reporter: Alexander Klimetschek
> Labels: i18n
> Attachments: SLING-3407.patch
>
>
> Currently there is the ResourceBundleProvider service interface, which really
> is an SPI, now that you can have multiple of them. The right way of accessing
> them is to get all service references, sort by service ranking (highest
> first) and then take the result from the first one that doesn't give you a
> null result (null resource bundle from getResourceBundle()). This is done in
> the I18nFilter and is quite a bit of boilerplate that client code should not
> have to worry about.
> Thus there should be a new API, something like a ResourceBundleManager with
> the 2 methods for getResourceBundle() (with basename and without).
> [1]
> http://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/I18NFilter.java
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
