[
https://issues.apache.org/jira/browse/SLING-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919059#comment-13919059
]
Stefan Scheidewig edited comment on SLING-3430 at 3/4/14 6:47 AM:
------------------------------------------------------------------
For me this optimization results in a failing build executing the
org.apache.sling.models.it.ViaTest (more precisely at the method
org.apache.commons.beanutils.PropertyUtils#getProperty(java.lang.Object,
java.lang.String)). The attempt to spot and add the needed classes may prove
very lengthy and could result in a org.apache.sling.models.impl artifact that
is potentially missing some dependencies on several execution paths. Maybe the
file size can be decreased by excluding some packages that will definitely not
be needed.
A second look at the commons-beanutils:commons-beanutils:1.8.3 artifact
revealed that it has a size of about 227 KB. Is it really worth to cut off
stability for such a small embedded dependency?
was (Author: thalis):
For me this optimization results in a failing build executing the
org.apache.sling.models.it.ViaTest (more precisely at the method
org.apache.commons.beanutils.PropertyUtils#getProperty(java.lang.Object,
java.lang.String)). The attempt to spot and add the needed classes may prove
very lengthy and could result in a org.apache.sling.models.impl artifact that
is potentially missing some dependencies on several execution paths. Maybe the
file size can be decreased by excluding some packages that will definitely not
be needed.
> No need to embed entire beanutils in Sling Models impl
> ------------------------------------------------------
>
> Key: SLING-3430
> URL: https://issues.apache.org/jira/browse/SLING-3430
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Implementation 1.0.0
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Sling Models Implementation 1.0.2
>
>
> Currently the entire beanutils jar is embedded. Likely only a relatively
> small subset is necessary.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
