[ 
https://issues.apache.org/jira/browse/SLING-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949028#comment-13949028
 ] 

Tommaso Teofili commented on SLING-3480:
----------------------------------------

the patch looks generally good, however I think there's one thing to fix in 
ReplicationITBase#assertJsonResponseContains as  {code}
        for (int i = 0; i < parameters.length; i += 2) {
            content.contains("\"" + parameters[i] + "\":\"" + parameters[i + 1] 
+ "\"");
        }
{code}
doesn't actually checks if the parameters are contained in the JSON String, 
also after adding assertTrue(content.contains ... the test fails so it'd be 
good to have that line fixed.

> Adding test for replication config delete
> -----------------------------------------
>
>                 Key: SLING-3480
>                 URL: https://issues.apache.org/jira/browse/SLING-3480
>             Project: Sling
>          Issue Type: Test
>          Components: Extensions
>            Reporter: Marius Petria
>            Assignee: Tommaso Teofili
>            Priority: Minor
>         Attachments: SLING-3480.patch
>
>
> Adding test for replication config delete and also fixing the test for config 
> create,



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to