On Apr 4, 2014, at 9:54 AM, Carsten Ziegeler <[email protected]> wrote:
> So we could just add the check to the getPath() method, and this should fix > the problem, right? > I think so. At that point we can as well remove the associated getAnonymousCredentials() since getPath can never be empty anymore. Will be at least “/“ regards antonio > Carsten > > > 2014-04-04 9:11 GMT+02:00 Antonio Sanso <[email protected]>: > >> hi carsten >> On Apr 3, 2014, at 6:34 PM, Carsten Ziegeler <[email protected]> wrote: >> >>> Hi Antonio, >>> >>> where is the NPE happening? >> >> I copied the subject from SLING-722 . With the current code there is >> actual no NPE but some functional issue (see my mail to Oliver) >> >> regards >> >> antonio >> >>> >>> Carsten >>> >>> >>> 2014-04-03 16:12 GMT+02:00 Antonio Sanso <[email protected]>: >>> >>>> hi *, >>>> >>>> SLING-722 introduced an important fix to solve some issue related to >> sling >>>> being registered in a Servlet container. >>>> Unluckily this fix has been removed in SLING-2998. >>>> The rationale behind this is not too clear to me. I am not against >>>> SLING-2998 per se. >>>> I think though that SLING-2998 should also contain the fix contained in >>>> SLING-722. >>>> >>>> @oliver WDYT? >>>> >>>> regards >>>> >>>> antonio >>>> >>>> >>>> [0] https://issues.apache.org/jira/browse/SLING-722 >>>> [1] https://issues.apache.org/jira/browse/SLING-2998 >>> >>> >>> >>> >>> -- >>> Carsten Ziegeler >>> [email protected] >> >> > > > -- > Carsten Ziegeler > [email protected]
