[
https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998721#comment-13998721
]
Konrad Windszus commented on SLING-3499:
----------------------------------------
Hi Justin, the patch looks fine to me, but please make sure that the changed
handling of default values is not overwritten (SLING-3547). I definitely
appreciate your changes. There is only one thing which should be changed which
is the Javadoc for InjectAnnotationProcessor.isOptional(). There is some copy
paste mistake in there. It should rather state that three values are supported
as return values: true, means the injection can be left out, false means it is
mandatory and null means the value from the Optional annotation is taken.
> Support custom annotations with Sling Models
> --------------------------------------------
>
> Key: SLING-3499
> URL: https://issues.apache.org/jira/browse/SLING-3499
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
> Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2
> Reporter: Konrad Windszus
>
> To support custom annotations the API needs to be extended.
> The reasons for custom annotations are listed in
> http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is
> much more comfortable for developers, since they can use code completion in
> the IDE to see which options are available for each injector-specific
> annotation, apart from that it is less code to write (instead of multiple
> annotations on one field/method I would only have to write one annotation
> with some attributes).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
