As discussed in SLING-3664 the new TEI classes are breaking the integration tests and change the behavior of some of the tags, specifically:
- In adaptTo it causes the JSP to fail to compile when specifying an invalid class instead of just returning null as is the usual Sling behavior - in getProperty it causes the JSP to fail to compile if neither a defaultValue nor a returnClass are specified If we cannot provide backwards compatibly for these issues, I suggest we at least remove the TEI classes for these tags. Thanks, Dan On Thu, Apr 24, 2014 at 8:36 AM, Julian Sedding <[email protected]> wrote: > Updated the patch in SLING-3475 to provide TEI implementations for all > tags in the Sling taglib. > > Regards > Julian > > On Wed, Apr 23, 2014 at 5:03 PM, Konrad Windszus <[email protected]> wrote: > > I definitely agree here. Including the TEI is almost no risk but it > helps a lot during development (at least with IntelliJ, because Eclipse > still lacks decent EL code completion support) > > > > On 23 Apr 2014, at 16:52, Julian Sedding <[email protected]> wrote: > > > >> Hi all > >> > >> It would be great to get the patch for SLING-3475 applied soon. > >> > >> The added TagExtraInfo should be low risk, as it should not impact > >> run-time behavior at all. > >> > >> However, enabling my IDE to help prevent small bugs would be very > >> helpful. Especially in conjunction with Sling Models, which make the > >> <sling:adaptTo/> tag much more useful. > >> > >> Thanks & regards > >> Julian > >> > >> https://issues.apache.org/jira/browse/SLING-3475 > > >
