[
https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036029#comment-14036029
]
Justin Edelson commented on SLING-3505:
---------------------------------------
I reviewed the patch (obviously based on my comments above). It looks like a
very strong start. I am concerned about sling:vanityOrder. It is not clear to
me how that will be supported as we will need to "remember" the conflicts
somewhere. Consider this scenario:
/content/mysite/jcr:content@sling:vanityPath=/mysite
/content/mysite/jcr:content@sling:vanityOrder=500
/content/myothersite/jcr:content@sling:vanityPath=/mysite
/content/myothersite/jcr:content@sling:vanityOrder=1000
At start, /mysite should redirect to /content/myothersite.html. This part
appears to be working.
Now I change /content/myothersite/jcr:content@sling:vanityPath to /mysite2 (or
change sling:vanityOrder to 400), we need to "promote" the shadowed vanity. It
isn't clear to me how this will work with the new structure.
> Improve handling of updates to mapping (alias, vanity path)
> -----------------------------------------------------------
>
> Key: SLING-3505
> URL: https://issues.apache.org/jira/browse/SLING-3505
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.1.0
> Reporter: Carsten Ziegeler
> Assignee: Antonio Sanso
> Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt,
> SLING-3505-patch2.txt
>
>
> The update handling for the mapping including aliases and vanity path is a
> simple algorithm which simply updates the whole mapping. Especially with
> large mapping info spread across the repository, a simple update of a single
> property results in the whole mapping info to be recreated.
> It would be great if this could be improved.
> Right now, only the active mapping is hold in memory - as a change of a
> single property might cause to activate a totally different mapping than the
> one which was changed (e.h. when the ordering is changed), the update needs
> to be more complex or more information needs to be hold in memory.
> In addition there is more to consider, like if the vanity path info is
> changed, only the new value is available - but the old is gone.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
