[ 
https://issues.apache.org/jira/browse/SLING-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061992#comment-14061992
 ] 

Bertrand Delacretaz commented on SLING-3762:
--------------------------------------------

Thanks for your patch - some tests fail if I apply it, IIUC the 
org.apache.sling.testing.samples.sampletests bundle  is missing the 
org.junit.internal.runners.statements package.

Steps to reproduce, after applying your patch:
{code}
export PL=$(find testing -name pom.xml | grep -v target | while read p; do echo 
-n "$(dirname $p),"; done)
mvn clean install -pl $PL
{code}

The testing/samples/integration-tests build fails, starting bundle 
org.apache.sling.testing.samples.sampletests fails, [1] shows an unresolved 
constraint error.

[1] testing/samples/integration-tests/sling/instance2/logs/error.log 



> Add annotation support to the PerformanceRunner
> -----------------------------------------------
>
>                 Key: SLING-3762
>                 URL: https://issues.apache.org/jira/browse/SLING-3762
>             Project: Sling
>          Issue Type: Bug
>            Reporter: Francesco Mari
>            Priority: Minor
>         Attachments: SLING-3762-001.patch
>
>
> I added support for annotations for tests executed with the 
> PerformanceRunner. These annotations allow you to define some methods in the 
> test to be run before or after warm up or performance iterations of the 
> performance test.
> This mechanism allow a user to write workflow control code directly in the 
> test, instead of relying on a Listener to perform appropriate initialization 
> and cleanup of test data.
> At the same time, the annotations I added play nice with the rest of the 
> standard JUnit annotations. You can always use standard before and after 
> annotations, and rules too. The patch contains a test which proves how the 
> new annotations fit with the performance listeners and with standard JUnit 
> annotations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to