[ 
https://issues.apache.org/jira/browse/SLING-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105187#comment-14105187
 ] 

Stefan Seifert commented on SLING-3715:
---------------------------------------

yes, you're right, the service ranking should be higher to allow other 
name-based injections step in first, although only few of them will inject 
resources.

there is some overlap with the "SlingBindings" injector, which allows to inject 
request, response and resource as well (but on pure name-based approach using 
the constants defined in the SlingBindings class).


> Sling Models: Support for class-based dependency injection
> ----------------------------------------------------------
>
>                 Key: SLING-3715
>                 URL: https://issues.apache.org/jira/browse/SLING-3715
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Stefan Seifert
>            Priority: Minor
>              Labels: models
>         Attachments: 140820_SLING-3715_sling-object-injector.patch
>
>
> Currently Sling Models dependency injection is primary based on parameter 
> name-based injection, and not on class-based injection (the latter is more 
> common in Spring and comparable frameworks).
> here is Justins opinion on this topic (from the mailing list) and why he 
> prefers name-based injection:
> {quote}
> Hi Stefan,
> The big problem IMHO with injecting by class vs. name is that by class
> is too ambigious in many cases. For example, in AEM, it is relatively
> common to want to inject a Page object, but in fact there are two
> different page objects which come into play (currentPage and
> resourcePage) and getting the wrong one could be highly problematic.
> You are correct that things like the request and response could
> presumably be injected by class rather than by name, but the question
> then becomes how do we judge these cases? In my opinion, the bindings
> names are sensible. I personally don't find myself wanting to write
> this very often:
> {code:java}
> @Inject
> private SlingHttpServletRequest somenameOtherThanRequest;
> {code}
> \[...\]
> Regards,
> Justin
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to