[
https://issues.apache.org/jira/browse/SLING-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-3892:
-----------------------------------
Description:
The AdapterWebConsolePlugin does not expose all AdapterFactories because it
relies on on a Map which uses the service as the key instead of the
ServiceReference
(https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterWebConsolePlugin.java#L110).
That is a problem for all adapters being registered through Sling Models
because that is reusing the same service instance for registering all
adapterFactories
(https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelPackageBundleListener.java#L100).
Please change that map so that the reference acts as key instead of the service
itself. Otherwise each time the {{addServiceMetadata}} is called, it will
overwrite the previous AdaptableDescription.
was:
The AdapterWebConsolePlugin does not expose all AdapterFactories because it
relies on on a Map which uses the service as the key instead of the
ServiceReference
(https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterWebConsolePlugin.java#L110).
That is a problem for all adapters being registered through Sling Models
because that is reusing the same service instance for registering all
adapterFactories
(https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelPackageBundleListener.java#L100).
Please change that map so that the reference acts as key instead of the service
itself.
> AdapterWebConsolePlugin does not expose all AdapterFactories
> ------------------------------------------------------------
>
> Key: SLING-3892
> URL: https://issues.apache.org/jira/browse/SLING-3892
> Project: Sling
> Issue Type: Bug
> Affects Versions: Adapter 2.1.0
> Reporter: Konrad Windszus
> Priority: Critical
>
> The AdapterWebConsolePlugin does not expose all AdapterFactories because it
> relies on on a Map which uses the service as the key instead of the
> ServiceReference
> (https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterWebConsolePlugin.java#L110).
> That is a problem for all adapters being registered through Sling Models
> because that is reusing the same service instance for registering all
> adapterFactories
> (https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelPackageBundleListener.java#L100).
> Please change that map so that the reference acts as key instead of the
> service itself. Otherwise each time the {{addServiceMetadata}} is called, it
> will overwrite the previous AdaptableDescription.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
