[
https://issues.apache.org/jira/browse/SLING-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152233#comment-14152233
]
Stefan Seifert commented on SLING-3511:
---------------------------------------
the patch looks good from my side.
i would be good to have a basic unit test coverage for the new code added.
unfortunately there are no unit tests currently in the project - but it should
be easy add a mockito-based unit test for the match method with the new
selector logic - do you have the possibility to update the patch accordingly?
this code is difficult to test manually without further context.
> Support selectors for pipeline configuration
> --------------------------------------------
>
> Key: SLING-3511
> URL: https://issues.apache.org/jira/browse/SLING-3511
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: Extensions Rewriter 1.0.4
> Reporter: Dirk Rudolph
> Priority: Minor
> Fix For: Extensions Rewriter 1.0.6
>
> Attachments: rewriter-selectors-support.patch
>
>
> Currently paths, contentTypes, extensions and resourceTypes are available for
> filtering pipeline configurations. I would be appreciated when filtering by
> selector would also be possible.
> We have an intranet/internet application that sends newsletters to different
> groups of users. Some of the users have to access the links provided in the
> generated mails trough a portal application. Due to some other rewriting we
> apply to the links it is necessary to append a prefix to the links in the
> last step of output rewriting but only for a special selector (we use
> someresource.mail.html as representation of the "this is a mail" view).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
