[
https://issues.apache.org/jira/browse/SLING-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163177#comment-14163177
]
ASF GitHub Bot commented on SLING-4012:
---------------------------------------
GitHub user kwin opened a pull request:
https://github.com/apache/sling/pull/29
SLING-4012, do not catch SlingValidationExceptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwin/sling
SLING-4012-rethrow-SlingValidationException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit bec979a16425a111bb2b37c5b6824e20b3c4617f
Author: Konrad Windszus <[email protected]>
Date: 2014-10-08T06:53:59Z
SLING-4012, do not catch SlingValidationExceptions
----
> Do not catch SlingValidationExceptions in the ValidationServiceImpl.java
> ------------------------------------------------------------------------
>
> Key: SLING-4012
> URL: https://issues.apache.org/jira/browse/SLING-4012
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: Konrad Windszus
> Labels: validator
>
> Currently all SlingValidationExceptions are caught in the
> ValidationServiceImpl.java
> (https://github.com/apache/sling/blob/trunk/contrib/validation/core/src/main/java/org/apache/sling/validation/impl/ValidationServiceImpl.java#L384).
> Since those exceptions should only happen during development, it would be
> very good, if those exceptions would not be caught by the
> ValidationServiceImpl. That way the exception is printed in most of the cases
> directly into the response (i.e. is easier to see during development time).
> Also features like a custom exception handler (through a servlet filter) or
> the AEM error filter could be used to expose that exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
