[
https://issues.apache.org/jira/browse/SLING-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207849#comment-14207849
]
ASF GitHub Bot commented on SLING-4155:
---------------------------------------
GitHub user kwin opened a pull request:
https://github.com/apache/sling/pull/33
SLING-4155, support default injections strategy for injector specific
annotations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwin/sling SLING-4155
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 99352b0048cb1c69524753cfbb1b1f41fa47254e
Author: Konrad Windszus <[email protected]>
Date: 2014-11-12T09:11:30Z
SLING-4155, modify optional field within all Injector-specific
annotations to support three values: TRUE, FALSE and DEFAULT
----
> DefaultInjectionStrategy does not support injector-specific annotations
> -----------------------------------------------------------------------
>
> Key: SLING-4155
> URL: https://issues.apache.org/jira/browse/SLING-4155
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Implementation 1.0.6
> Reporter: Konrad Windszus
>
> The default injection strategy (being implemented in SLING-3696) is only
> considered, in case there is no injector-specific annotation being used.
> Otherwise it is just ignored.
> The logic should be like this:
> if annotationProcessor.isOptional() returns null
> -> the default injection strategy should be used
> in any other case the boolean value should be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
