[ 
https://issues.apache.org/jira/browse/SLING-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208380#comment-14208380
 ] 

Bertrand Delacretaz commented on SLING-4151:
--------------------------------------------

Thanks, this looks good to me, just two things.

The scripts (all non-trivial source code actually) need the Apache license 
header, you can find the text at http://www.apache.org/legal/src-headers.html 
("Each source file should include the following license header"). Could you add 
them? I don't have a setup to test the package so it's probably easier for you 
to verify that they don't break the scripts. 

src/deb/control/control contains your email as the maintainer address. We 
discussed changing it but IIUC it would be better to avoid sending it to our 
dev@ list, so if you agree I suggest keeping it as is. The only downside is 
that you might get lots of mail if the package is successful ;-)

> Create debian/.ubuntu package for sling launchpad standalone jar
> ----------------------------------------------------------------
>
>                 Key: SLING-4151
>                 URL: https://issues.apache.org/jira/browse/SLING-4151
>             Project: Sling
>          Issue Type: New Feature
>          Components: Installer
>            Reporter: Bruce Edge
>            Priority: Minor
>              Labels: debian, install, package, ubuntu
>         Attachments: sling-dpkg.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I’m setting up a development env for a team to work on a sling asset manager 
> app. I wanted to make the env setup simple so I put together a debian/ubuntu 
> package for the org.apache.sling.launchpad-8-SNAPSHOT-standalone.jar.
> It uses the jdeb maven plugin so it’s cross-platform. Here’s the patch on the 
> off-chance it’s compatible with the upstream policies. If it needs tuning, 
> let me know what it’s missing.
> Comments from dev list:
> - Do you mind creating a JIRA 
> - my preference would be to have this in contrib instead of the launchpad 
> folder 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to