[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237825#comment-14237825
]
santiago garcía pimentel edited comment on SLING-4212 at 12/8/14 12:37 PM:
---------------------------------------------------------------------------
while changing this I found myself a bit confused with a specific test for the
injector.
{quote}ResourcePathInjectionTest.testOptionalPathInjectionWithNonResourceAdaptable{quote}
adapts a request to ResourcePathAllOptionalModel and expects property
'fromPath' to be null. why is this? it is possible to obtain a resourceResolver
from the request and find a resource from a path set in the annotation.
was (Author: santiagozky):
while changing this I found myself a bit confused with a specific test for the
injector.
{code}ResourcePathInjectionTest.testOptionalPathInjectionWithNonResourceAdaptable{code}
adapts a request to ResourcePathAllOptionalModel and expects property
'fromPath' to be null. why is this? it is possible to obtain a resourceResolver
from the request and find a resource from a path set in the annotation.
> Sling Models: Allow multiple values from ValueMap in the resource-path
> injector
> -------------------------------------------------------------------------------
>
> Key: SLING-4212
> URL: https://issues.apache.org/jira/browse/SLING-4212
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: santiago garcía pimentel
> Attachments: resourcePath.patch
>
>
> The current implementation of the resource-path injector does not support
> multiple values. I think it could be useful to inject a list of paths from
> the valuemap.
> I have created a small patch to allow this. Right now it only allows them
> from the value map since I didn't want to change the API without consulting
> you first. I you agree I can do this change as well. I also added a test case
> for it.
> You can see a pull request in https://github.com/apache/sling/pull/51
> If there anything I can do to improve this patch, please let me know.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)