[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237844#comment-14237844
]
Konrad Windszus commented on SLING-4212:
----------------------------------------
[~santiagozky]
{{ResourcePathInjectionTest.testOptionalPathInjectionWithNonResourceAdaptable}}
expects null for all model fields, because you act on a mocked
{{SlingHttpServletRequest}}. That will return {{null}} for all getters.
Therefore the injector is not able to find out the according
{{ResourceResolver}}. Regarding the other question, Injectors are not
allowed/expected to throw exceptions. Therefore please log that accordingly in
the Injector and rather return {{null}} (i.e. no injection should take plae).
If you would just inject the first resource, then the error is not that obvious
to the developer any more.
> Sling Models: Allow multiple values from ValueMap in the resource-path
> injector
> -------------------------------------------------------------------------------
>
> Key: SLING-4212
> URL: https://issues.apache.org/jira/browse/SLING-4212
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: santiago garcía pimentel
> Attachments: resourcePath.patch
>
>
> The current implementation of the resource-path injector does not support
> multiple values. I think it could be useful to inject a list of paths from
> the valuemap.
> I have created a small patch to allow this. Right now it only allows them
> from the value map since I didn't want to change the API without consulting
> you first. I you agree I can do this change as well. I also added a test case
> for it.
> You can see a pull request in https://github.com/apache/sling/pull/51
> If there anything I can do to improve this patch, please let me know.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
