On Wed, 2014-12-10 at 17:14 +0100, Konrad Windszus wrote: > Does this already refer to a specific Sling issue? Was it an alternative > solution for the problem listed in > https://issues.apache.org/jira/browse/SLING-4217? > <https://issues.apache.org/jira/browse/SLING-4217?> > Sorry, I may have missed the point here.
It's an additional convenience annotation for SLING-4217. Right now you need to use a quite verbose @Reference to wait for an AdapterFactory to be available. This review prototypes a SCR annotation which would hide that complexity. Robert > Thanks for any clarification, > Konrad > > > On 05 Dec 2014, at 21:03, Felix Meschberger <[email protected]> wrote: > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/28758/ > > ----------------------------------------------------------- > > > > Review request for sling. > > > > > > Summary (updated) > > ----------------- > > > > @AdapterReference annotation prototype > > > > > > Repository: sling > > > > > > Description (updated) > > ------- > > > > SLING-4217 - Register OSGi services corresponding to available adapter > > factories > > > > > > Diffs (updated) > > ----- > > > > bundles/extensions/adapter/pom.xml 1643271 > > > > bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/ds/AdapterReference.java > > PRE-CREATION > > > > bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/ds/AdapterReferenceAnnotationProcessor.java > > PRE-CREATION > > > > bundles/extensions/adapter/src/main/resources/META-INF/services/org.apache.felix.scrplugin.annotations.AnnotationProcessor > > PRE-CREATION > > > > Diff: https://reviews.apache.org/r/28758/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Felix Meschberger > > >
