[
https://issues.apache.org/jira/browse/SLING-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274089#comment-14274089
]
Felix Meschberger commented on SLING-4298:
------------------------------------------
I have the impression, that this does not give good coding ... The
CaptureResponseWrapper takes a byte-based ServletOutputStream which is only
used to acutally capture the output of CaptureResponseWrapper.getWriter.
We should look at what the goal actually is: capturing the output of the
wrapped response. Maybe it is simpler to actually have the
CaptureResponseWrapper internally capture the character output in a
StringWriter which is made available through a "getString()" or so method.
> make BufferedServletOutputStream and CaptureResponseWrapper available to
> other scripting implementations
> --------------------------------------------------------------------------------------------------------
>
> Key: SLING-4298
> URL: https://issues.apache.org/jira/browse/SLING-4298
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Reporter: Oliver Lietz
> Assignee: Oliver Lietz
> Fix For: Scripting Core 2.0.30, Scripting JSP-Taglib 2.2.6
>
>
> move private (inner) classes {{BufferedServletOutputStream}} and
> {{CaptureResponseWrapper}}
> ({{org.apache.sling.scripting.jsp.taglib.IncludeTagHandler}}) from _Scripting
> JSP Taglib_ to _Scripting Core_
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
