[
https://issues.apache.org/jira/browse/SLING-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275505#comment-14275505
]
Carsten Ziegeler commented on SLING-4294:
-----------------------------------------
Patch looks basically good, I suggest two changes:
- update of the version of the exported package
- I would collapse the two filter case into one and then if the filter is not
selected and is the last one, call the renderer. This minimizes the code
duplication
> Servlet Filter Support adding sling.filter.pattern support
> ----------------------------------------------------------
>
> Key: SLING-4294
> URL: https://issues.apache.org/jira/browse/SLING-4294
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-4294-patch.txt
>
>
> the current Sling Servlet Filter Support [0] allows to have scope dependent
> filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT).
> It would be nice to extend this support to have a specific filter being taken
> in consideration only for specific path (adding sling.filter.pattern) a bit
> like what currently can be done for Apache Felix filters.
> mailing list discussion in [1]
> [0] http://sling.apache.org/documentation/the-sling-engine/filters.html
> [1] http://markmail.org/message/lzp7qcienk3blwpk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
