[ 
https://issues.apache.org/jira/browse/SLING-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280020#comment-14280020
 ] 

Bertrand Delacretaz commented on SLING-4320:
--------------------------------------------

ok, I'll review in detail once you commit your changes - please make those 
minimal (i.e. don't combine with other things) so we can see the actual impact.

> Make JUnit Core depend on JUnit and Hamcrest with Compile scope
> ---------------------------------------------------------------
>
>                 Key: SLING-4320
>                 URL: https://issues.apache.org/jira/browse/SLING-4320
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: JUnit Core 1.0.10
>            Reporter: Konrad Windszus
>
> Currently in org.apache.sling.junit.core (1.0.10) the dependency to JUnit and 
> Hamcrest has scope {{provided}}. It should rather have the scope {{compile}} 
> to ease writing of Remote Unit Test Bundles (because only dependencies with 
> {{compile}} scope would automatically be included transitively)
> Those bundles should only depend on sling.junit.core and transitively get the 
> dependencies for JUnit and Hamcrest. Otherwise you always need to figure out 
> manually which JUnit version and Hamcrest version is used by sling.junit.core 
> and add those dependencies manually in addition to the sling.junit.core 
> dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to