[
https://issues.apache.org/jira/browse/SLING-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282476#comment-14282476
]
Radu Cotescu edited comment on SLING-4307 at 1/19/15 1:21 PM:
--------------------------------------------------------------
The attached patch ([^SLING-4307_stream_test.patch]) proves that the code
committed in r1652218 / r1652219 introduced a regression when handling Binary
properties supplied to the {{JcrModifiableValueMap}} as an {{InputStream}}.
The provided test passes for r1640498, which is the last revision prior to
r1652218 where the code from {{org.apache.sling.jcr.resource}} was touched.
was (Author: radu.cotescu):
The attached patch ([^SLING-4307_stream_test.patch]) proves that the code
committed in rr1652218 / r1652219 introduced a regression when handling Binary
properties supplied to the {{JcrModifiableValueMap}} as an {{InputStream}}.
> Avoid caching JCR property values
> ---------------------------------
>
> Key: SLING-4307
> URL: https://issues.apache.org/jira/browse/SLING-4307
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Carsten Ziegeler
> Assignee: Bertrand Delacretaz
> Fix For: JCR Resource 2.4.0
>
> Attachments: SLING-4307_stream_test.patch
>
>
> The support for ValueMap is currently caching the JCR Value objects and also
> the JCR Property object.
> If the value map object is held, this might prevent garbage collection within
> Oak as the value object holds a reference to the revision.
> We should check whether caching is needed at all or if for example we could
> just cache the value itself but not the JCR Value object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
