[ 
https://issues.apache.org/jira/browse/SLING-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282540#comment-14282540
 ] 

Bertrand Delacretaz commented on SLING-4307:
--------------------------------------------

It looks like for some reason this

{code}
InputStream stream = new ByteArrayInputStream(TEST_BYTE_ARRAY);
pvm.put("binary", stream);
{code}

Causes org.apache.jackrabbit.core.value.ValueFactoryImpl.createBinary to be 
called twice.

The second time the stream is positioned at the end so no data is copied, and 
the stream contents are lost.

> Avoid caching JCR property values
> ---------------------------------
>
>                 Key: SLING-4307
>                 URL: https://issues.apache.org/jira/browse/SLING-4307
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>            Reporter: Carsten Ziegeler
>            Assignee: Bertrand Delacretaz
>             Fix For: JCR Resource 2.4.0
>
>         Attachments: SLING-4307_stream_test.patch
>
>
> The support for ValueMap is currently caching the JCR Value objects and also 
> the JCR Property object.
> If the value map object is held, this might prevent garbage collection within 
> Oak as the value object holds a reference to the revision.
> We should check whether caching is needed at all or if for example we could 
> just cache the value itself but not the JCR Value object



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to