[
https://issues.apache.org/jira/browse/SLING-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-4307:
------------------------------------------
Assignee: Carsten Ziegeler (was: Bertrand Delacretaz)
I have committed a tentative fix in http://svn.apache.org/r1653013 which might
not be optimal. Reassigning to [~cziegeler], I think you wrote this code, can
you review?
Radu's new test passes with my fix but there might be a cleaner way, for now I
wanted to touch your code as little as possible. Note that the double
conversion to createValue (one to check that you can store and a second one to
actually store) could be expensive anyway, so if there's a way to get rid of
them that's probably better.
> Avoid caching JCR property values
> ---------------------------------
>
> Key: SLING-4307
> URL: https://issues.apache.org/jira/browse/SLING-4307
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.4.0
>
> Attachments: SLING-4307_stream_test.patch
>
>
> The support for ValueMap is currently caching the JCR Value objects and also
> the JCR Property object.
> If the value map object is held, this might prevent garbage collection within
> Oak as the value object holds a reference to the revision.
> We should check whether caching is needed at all or if for example we could
> just cache the value itself but not the JCR Value object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
