[ 
https://issues.apache.org/jira/browse/SLING-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283984#comment-14283984
 ] 

Bertrand Delacretaz commented on SLING-4258:
--------------------------------------------

I have a slightly more extensive variant of 
JsonObjectCreatorTest.testCalendarTimezones below, and you could use the same 
cleaner pattern in SlingDateValuesTest.testDateTimezone. Can you add these two 
minor changes?

{code}
    @Test
    public void testCalendarTimezones() throws JSONException {
        final int [] offsets = { -14400000, -4200000, 14400000, 4300000 };
        for(int offset : offsets) {
            for(String tzId : TimeZone.getAvailableIDs(offset)) {
                final TimeZone tz =TimeZone.getTimeZone(tzId);
                final Calendar cal = Calendar.getInstance(tz);
                DateFormat fmt = new SimpleDateFormat(ECMA_DATE_FORMAT, 
Locale.ENGLISH);
                fmt.setTimeZone(tz);
                final String nowString = fmt.format(cal.getTime());
                assertGet(cal, nowString);
            }
        }
    }
{code}


> Please document better how dates are handled by the Post servlet
> ----------------------------------------------------------------
>
>                 Key: SLING-4258
>                 URL: https://issues.apache.org/jira/browse/SLING-4258
>             Project: Sling
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: santiago garcía pimentel
>
> Im currently doing some things with dates in Sling that involve timezones and 
> I find that the documentation regarding it is not particularly clear.
> according to 
> https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#date-properties
> several formats are defined. 
> I found that the only format that saves a provided timezone is the ISO8601 
> format, rest of them relies in a Date object, which does not have timezones. 
> Could this be clearly stated?
> Also, the ISO8601 parser is problematic. It relies on the Jackrabbit parser 
> which uses format "±YYYY-MM-DDThh:mm:ss.SSSTZD", but according to 
> http://www.w3.org/TR/NOTE-datetime the ISO format does not have milliseconds 
> on it ("SSS"). So it is very hard to find a way to keep the timezone 
> information (I had to dig through the code to figure it out)
> Could we please replace ISO8601 with the actual format 
> "±YYYY-MM-DDThh:mm:ss.SSSTZD" so it is clearer?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to