On Fri, Jan 23, 2015 at 11:39 AM, Tomek Rękawek <[email protected]> wrote: > Hello Robert, > > On Thu, Jan 22, 2015 at 11:23 AM, Robert Munteanu <[email protected]> > wrote: > >> Hi, >> >> While doing a recent build of SlingQuery I realized that all packages >> are exported with the project's version, so we need to add >> package-info.java files and start versioning. >> > > Thanks for pointing this out. Indeed, we should start versioning the > SlingQuery API. > > >> However, I am curious whether all packages are actually intended to be >> exported ( list below ) >> > > We should export following packages: > > * org.apache.sling.query (as it contains SlingQuery class, the entrypoint > to the whole library), > * org.apache.sling.query.api (Predicate, SearchStrategy and other types for > the queries customization), > > Other packages contains the implementation or the internal API (like > org.apache.sling.query.api.function) and don't have to be exposed > externally. > > Could you add appropriate package-info.java files to the two mentioned > packages? >
Filed https://issues.apache.org/jira/browse/SLING-4370 for it. I am not certain that we can remove the exported packages as we have already released them in 2.0.0. I guess this would warrant a bump of the version to 3.0.0 , but I'm curious about what others think. Robert > Best regards, > Tomek > > -- > Tomek Rękawek > Senior Software Engineer > > Cognifide Polska Sp. z o.o. > skype: trekawek > > www.cognifide.com
