[
https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317924#comment-14317924
]
Tomek Rękawek commented on SLING-848:
-------------------------------------
Thanks for the feedback!
{quote}
I had a brief look at the applied code and I think the parameters are not added
to the metadata in all cases, e.g. if getResource(Resource, String) is called,
this calls getResourceInternal(String) which then calls
getAbsoluteResourceInternal.
{quote}
You are right.
{quote}
In general I think we should add the parameters to the metadata in all places
where we do a setResolutionPath or setResolutionPathInfo; but not in any other
place, which I think there is one or two in the source.
{quote}
Good idea, it'll make the metadata-related code more consistent. Please find
the patch attached.
> Support getting versioned resources by using uri path parameters
> ----------------------------------------------------------------
>
> Key: SLING-848
> URL: https://issues.apache.org/jira/browse/SLING-848
> Project: Sling
> Issue Type: New Feature
> Components: JCR
> Affects Versions: JCR Resource 2.0.2
> Reporter: Carsten Ziegeler
> Assignee: Tomek Rękawek
> Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.1.14
>
> Attachments: SLING-848-metadata.patch
>
>
> Getting versioned content should be support thorough uri path parameters,
> like /something/hello;v=1.1
> For jcr based resources the value of the version should either point to a
> version name or label.
> In order to not change our existing apis, we introduce a new utility method
> which removes all uri path parameters
> and returns a map of these. Every resource provider could use this utility
> method and then decide to act on these
> parameters.
> If a requested version does not exists, a 404 is returned.
> If the requested node does not directly point to a versionable node, the
> algorithm checks the parent hierarchy until a versionable node is found, and
> tries to get the version of this node and then goes down the path again. If
> the versionable node does not have the requested version or the child, a 404
> is returned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
