Hi Robert, yes, I just noticed that. Since this is an optional dependency I would rather argue that this should be fine. Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo? Once we do have a Sightly release that should no longer be a problem. Konrad
> On 26 Feb 2015, at 14:34, Robert Munteanu <[email protected]> wrote: > > Hi Konrad, > > On Thu, 2015-02-26 at 12:27 +0000, [email protected] wrote: >> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml >> URL: >> http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff >> ============================================================================== >> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original) >> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 >> 2015 >> @@ -146,5 +146,19 @@ >> <scope>provided</scope> >> <optional>true</optional> >> </dependency> >> + <dependency> >> + <groupId>org.apache.sling</groupId> >> + <artifactId>org.apache.sling.scripting.sightly</artifactId> >> + <version>1.0.0-SNAPSHOT</version> >> + <scope>provided</scope> >> + <optional>true</optional> >> + </dependency> >> + <dependency> >> + <groupId>org.apache.sling</groupId> >> + <artifactId>org.apache.sling.commons.classloader</artifactId> >> + <version>1.3.0</version> >> + <scope>provided</scope> >> + <optional>true</optional> >> + </dependency> >> </dependencies> >> </project> > > (snip) > > This breaks the main build, since it can't find a sightly SNAPSHOT in > its reactor or on a repo. We could do a quick fix and deploy a sightly > SNAPSHOT but the question is whether this is the right thing to do. > > Since models is in bundles/extensions ( i.e. in the main build ) and > sightly in contrib I would argue that it's not right to place such > dependencies, and I would rather see an addon in contrib which provides > this functionality. > > WDYT? > > Cheers, > > Robert > >
