[
https://issues.apache.org/jira/browse/SLING-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379999#comment-14379999
]
ASF GitHub Bot commented on SLING-4546:
---------------------------------------
GitHub user vladbailescu opened a pull request:
https://github.com/apache/sling/pull/77
SLING-4546 - Sightly: Improper handling of extension and selectors by
data-sly-resource
- Improved selector extraction for resource path (taking extensions into
consideration)
- Added selectors from path or parent to dispatcher options so they will no
longer be ignored
- Updated testing content and integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladbailescu/sling
SLING-4546_improper_extension_selectors_in_data-sly-resource
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 6b4e0ec1ab1a38c771e0da3e8e86e3e4bcdca1f5
Author: vladbailescu <[email protected]>
Date: 2015-03-25T14:55:19Z
SLING-4546 - Sightly: Improper handling of extension and selectors by
data-sly-resource
- Improved selector extraction for resource path (taking extensions into
consideration)
- Added selectors from path or parent to dispatcher options so they will no
longer be ignored
- Updated testing content and integration tests
----
> Sightly: Improper handling of extension and selectors by data-sly-resource
> --------------------------------------------------------------------------
>
> Key: SLING-4546
> URL: https://issues.apache.org/jira/browse/SLING-4546
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Vlad Bailescu
> Fix For: Scripting Sightly Engine 1.0.2
>
>
> Sightly is not handling extensions and selectors properly in
> {{data-sly-resource}}:
> # Selectors included in path or parent resource are ignored if no
> selector-related option is specified
> # Extensions are ignored completely, Sightly assumes anything preceded by a
> dot is a selector
> This leads to:
> * {{'resource.selector.html'}} being equivalent to {{'resource'}} instead of
> {{'resource.html' @ selectors=\['selector'\]}}
> * {{'resource.selector.html' @ addSelectors=\['other'\]}} being equivalent to
> {{'resource' @ selectors=\['selector', 'html', 'other'\]}} instead of
> {{'resource.html' @ selectors=\['selector', 'other'\]}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
